Fixed phpdoc typo #695
Merged
Fixed phpdoc typo #695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acrobat
approved these changes
Mar 17, 2018
|
Can you just get StyleCI to fix up after? It has a setting which will auto-commit fixes after PRs are merged. |
|
I know. But I have a bad "feeling" about auto-committing to master without a review. |
|
It can also auto-send PRs and not merge them. :P |
|
Yeah I don't like "auto" fixing, it is for sure a nice feature. But we can just make each pr pass and we will be fine! I like it better that each pr is just "ok" and passes all validations before merging. |
|
ok, sure ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.