Skip to content

Allow data about our plugin to show up in Symfony debug toolbar #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 8, 2018
Merged

Allow data about our plugin to show up in Symfony debug toolbar #687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6fb09e
Allow data about our plugin to show up in Symfony webdebug bar
Nyholm Mar 6, 2018
baf3b2a
Update CHANGELOG.md
Nyholm Mar 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@

The change log describes what is "Added", "Removed", "Changed" or "Fixed" between each release.

## 2.8.0

### Added

- Allow our HTTP plugins to show up in the Symfony web profiler page.

## 2.7.0

### Added
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"php-http/httplug": "^1.1",
"php-http/discovery": "^1.0",
"php-http/client-implementation": "^1.0",
"php-http/client-common": "^1.3",
"php-http/client-common": "^1.6",
"php-http/cache-plugin": "^1.4"
},
"require-dev": {
Expand Down
3 changes: 2 additions & 1 deletion lib/Github/HttpClient/Builder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
use Http\Client\Common\Plugin;
use Http\Client\Common\Plugin\Cache\Generator\HeaderCacheKeyGenerator;
use Http\Client\Common\PluginClient;
use Http\Client\Common\PluginClientFactory;
use Http\Client\HttpClient;
use Http\Discovery\HttpClientDiscovery;
use Http\Discovery\MessageFactoryDiscovery;
Expand Down Expand Up @@ -102,7 +103,7 @@ public function getHttpClient()
}

$this->pluginClient = new HttpMethodsClient(
new PluginClient($this->httpClient, $plugins),
(new PluginClientFactory())->createClient($this->httpClient, $plugins),
$this->requestFactory
);
}
Expand Down