Skip to content

Pimp the readme with badge poser! #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 6, 2018
Merged

Pimp the readme with badge poser! #686

merged 2 commits into from
Mar 6, 2018

Conversation

JellyBellyDev
Copy link
Contributor

schermata 2018-03-05 alle 15 56 19

Nyholm
Nyholm requested changes Mar 5, 2018
View reviewed changes
Copy link
Collaborator

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. I like this. But I do not think the License is needed. It is already specified in the header:

screen shot 2018-03-05 at 16 15 50

@JellyBellyDev
Copy link
Contributor Author

Ok! I override badge license with Monthly Downloads! ;)

Nyholm
Nyholm approved these changes Mar 6, 2018
View reviewed changes
Copy link
Collaborator

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent

@Nyholm Nyholm merged commit a173d54 into KnpLabs:master Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

@acrobat acrobat acrobat approved these changes

@m1guelpf m1guelpf m1guelpf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JellyBellyDev @Nyholm @acrobat @m1guelpf