README: drop outdated info, simplify install #645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acrobat
reviewed
Nov 12, 2017
README.md
Outdated
| * [branch](https://github.com/KnpLabs/php-github-api/tree/1.7) | ||
| * [readme](https://github.com/KnpLabs/php-github-api/tree/1.7/README.md) | ||
| * [docs](https://github.com/KnpLabs/php-github-api/tree/1.7/doc) | ||
| # PHP GitHub API 3.0 |
There was a problem hiding this comment.
Why the 3.0? This library is still in the 2.x cycle
There was a problem hiding this comment.
More relevant information is rather Uses GitHub API v3
Most recent version of this package is already in released, no need to duplicated it in README, moreover in composer time.
There was a problem hiding this comment.
👎 Should be reverted. This is the name of the package, not of the API.
There was a problem hiding this comment.
Version is not a name, but I see your points.
Let's make it PHP GitHub API then to prevent ambiguity.
|
Is there anything else that needs to be done? This is quite easy pick |
|
Thanks @TomasVotruba! |
|
Awesome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.