Upgrade phpunit dependency to supported versions #631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm the problem is that phpunit 5 only supports 5.6+. Is this a good time to bump the php version to |
|
@Nyholm what do you think? Are you ok with bumping php to 5.6? |
m1guelpf
approved these changes
Oct 5, 2017
acrobat
force-pushed
the
phpunit-upgrade
branch
2 times, most recently
from
d418e2a to
e7bb926
Compare
|
Version is bumped to php 5.6 and tests pass. Merging this tomorrow if no comments come in! |
acrobat
force-pushed
the
phpunit-upgrade
branch
from
e7bb926 to
cac96bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phpunit 4.x is not supported anymore. So I've upgraded our dependency to ^5.5|^6.0 and used the forward compatibility layer (phpunit 5) for the support of namespaces.