-
-
Notifications
You must be signed in to change notification settings - Fork 598
Support v4 API #593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support v4 API #593
Conversation
Should we add a |
lib/Github/Api/GraphQL.php
Outdated
@@ -2,23 +2,27 @@ | |||
|
|||
namespace Github\Api; | |||
|
|||
use AcceptHeaderTrait; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this use (duplicate use on line 17)
* @author Miguel Piedrafita <soy@miguelpiedrafita.com> | ||
*/ | ||
class GraphQL extends AbstractApi | ||
{ | ||
use AcceptHeaderTrait; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing newline after the semicolon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me! @Nyholm any remarks?
Looks good to me, thanks @m1guelpf! |
See #591