Skip to content

Support v4 API #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 25, 2017
Merged

Support v4 API #593

merged 10 commits into from
May 25, 2017

Conversation

m1guelpf
Copy link
Contributor

@m1guelpf m1guelpf commented May 22, 2017

See #591

@m1guelpf m1guelpf changed the title GraphQL Out of Beta Support v4 API May 22, 2017
@acrobat
Copy link
Collaborator

acrobat commented May 22, 2017

Should we add a configure method or set the correct api version automatically in the execute method?

@m1guelpf
Copy link
Contributor Author

@acrobat @Nyholm Done!

@@ -2,23 +2,27 @@

namespace Github\Api;

use AcceptHeaderTrait;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this use (duplicate use on line 17)

* @author Miguel Piedrafita <soy@miguelpiedrafita.com>
*/
class GraphQL extends AbstractApi
{
use AcceptHeaderTrait;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing newline after the semicolon

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link
Collaborator

@acrobat acrobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me! @Nyholm any remarks?

@acrobat
Copy link
Collaborator

acrobat commented May 25, 2017

Looks good to me, thanks @m1guelpf!

@acrobat acrobat merged commit 6a9e6fb into KnpLabs:master May 25, 2017
@m1guelpf m1guelpf deleted the patch-2 branch May 25, 2017 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants