Skip to content

Fixed CS #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 31, 2013
Merged

Fixed CS #54

merged 2 commits into from
Aug 31, 2013

Conversation

lyrixx
Copy link
Contributor

@lyrixx lyrixx commented May 17, 2013

No description provided.

@lyrixx
Copy link
Contributor Author

lyrixx commented Jun 4, 2013

ping

@lyrixx
Copy link
Contributor Author

lyrixx commented Jul 7, 2013

pong :)

@verschoof
Copy link
Contributor

👍

1 similar comment
@ramondelafuente
Copy link
Contributor

👍

@@ -35,4 +35,3 @@ public function get($id);
*/
public function set($id, Response $response);
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's what i did

@pilot
Copy link
Contributor

pilot commented Aug 30, 2013

@lyrixx rebase pls

@lyrixx
Copy link
Contributor Author

lyrixx commented Aug 31, 2013

@pilot Rebased. tests does not passe as on master. Anyway, I just changed CS and remove some unuse statement.

pilot added a commit that referenced this pull request Aug 31, 2013
@pilot pilot merged commit 1b1042f into KnpLabs:master Aug 31, 2013
@pilot
Copy link
Contributor

pilot commented Aug 31, 2013

thanks, good job!

@lyrixx lyrixx deleted the cs branch August 31, 2013 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants