Add ability to define parameters for /users/{user}/starred #536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j0k3r
changed the title
Following the documentation (https://developer.github.com/v3/activity/starring/#list-repositories-being-starred) we can define few parameters to the request: - page (was already available in the lib) - per_page - sort - direction
Nyholm
reviewed
Mar 7, 2017
There was a problem hiding this comment.
Thank you. It looks good.
I cannot find the docs saying page, per_page and direction exists. (Looked here: https://developer.github.com/v3/activity/starring/) Can you please link me that docs?
|
I put the link in the PR description 🙂 That doc doesn't mention the |
|
Thanks! Too bad it's not in 2.1.0 |
|
2.2 will come today (or worst case this week). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the documentation we can define few parameters to the request:
I also fixed a small typo.