Missing miscellaneous api endpoints #534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1guelpf
approved these changes
Mar 5, 2017
Nyholm
approved these changes
Mar 23, 2017
There was a problem hiding this comment.
Awesome. Thank you.
No I do not think you can move existing classes. That would be a BC break, even though most people would never care..
If you want to you may deprecate the current classes and make then extend a new class in the correct namespace. But that is a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm checking the lib to see if we missed any api endpoints available. This PR fixes the missing miscellaneous api endpoints.
@Nyholm what do you think? Can we move the markdown, ratelimit, etc api classes to the miscellaneous subfolder/namespace to mimic the structure github has for these api's? See: https://developer.github.com/v3/misc/
It would not change how the user would use these api's as $client->api('ratelimit') and $client->ratelimit() would point to the correct class.