Skip to content

Add branch protection #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 9, 2017
Merged

Add branch protection #520

merged 2 commits into from
Feb 9, 2017

Conversation

ampersand
Copy link
Contributor

Copy link
Collaborator

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. I just miss some docs.

*/
class Protection extends AbstractApi
{
public function show($username, $repository, $branch)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add method comments with parameters and their types, link to docs and return value

return $this->get('/repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/branches/'.rawurlencode($branch).'/protection');
}

public function update($username, $repository, $branch, array $params = array())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@Nyholm
Copy link
Collaborator

Nyholm commented Feb 9, 2017

Excellent. Thank you @ampersand!

@Nyholm Nyholm merged commit bf37870 into KnpLabs:master Feb 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants