Skip to content

Add page variable to organization repo list #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 1, 2017
Merged

Add page variable to organization repo list #518

merged 2 commits into from
Feb 1, 2017

Conversation

MatissJanis
Copy link
Contributor

If an organization has more than 30 repositories, this allows to perform subsequent requests to get all of the repositories.

@Nyholm
Copy link
Collaborator

Nyholm commented Feb 1, 2017

Thank you for this PR.
Can you also update the tests?

@MatissJanis
Copy link
Contributor Author

Done 👍

@Nyholm Nyholm merged commit 875971e into KnpLabs:master Feb 1, 2017
@Nyholm
Copy link
Collaborator

Nyholm commented Feb 1, 2017

Awesome. Thanks

@martinssipenko
Copy link
Contributor

Aren't you supposed to use Paginator to do this?
https://github.com/KnpLabs/php-github-api/blob/master/doc/result_pager.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MatissJanis @Nyholm @martinssipenko