add support for the pull request reviews API #517
Conversation
| @@ -127,7 +127,7 @@ public function __construct(Builder $httpClientBuilder = null, $apiVersion = nul | |||
| ))); | |||
|
|
|||
| $this->apiVersion = $apiVersion ?: 'v3'; | |||
| $builder->addHeaders(['Accept' => sprintf('application/vnd.github.%s+json', $this->apiVersion)]); | |||
| $builder->addHeaderValue('Accept', sprintf('application/vnd.github.%s+json', $this->apiVersion)); | |||
There was a problem hiding this comment.
Otherwise we wouldn't be able to add the custom Accept header value without having to repeat Accept header values passed by this builder.
|
@m1guelpf Can you explain why this would break Laravel Github? |
|
@m1guelpf I don't see why that should break. Which error message do you get? |
|
@xabbuh Forget it, I reinstalled everything and now it works. |
There was a problem hiding this comment.
Thank you. I think it all looks good. I just had some minor things.
Is there any reson why you left Get comments for single review for a future update?
| return $this->get('/repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/pulls/'.rawurlencode($pullRequest).'/comments'); | ||
| } | ||
|
|
||
| return $this->get('/repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/pulls/comments'); |
There was a problem hiding this comment.
This change is not really a part of the PR, right?
Let's keep it anyways (for this time)
There was a problem hiding this comment.
Actually, it's there to allow https://developer.github.com/v3/pulls/comments/#list-comments-in-a-repository which is not directly related to the reviews, but needed if you want to fully leverage the reviews API. But I can move it to its own PR nonetheless. What do you think?
There was a problem hiding this comment.
Okey, I stand corrected.
Lets keep it.
| /** | ||
| * Get a listing of a pull request's reviews by the username, repository and pull request number. | ||
| * | ||
| * @link http://developer.github.com/v3/pulls/ |
There was a problem hiding this comment.
| /** | ||
| * Get a single pull request review by the username, repository, pull request number and the review id. | ||
| * | ||
| * @link http://developer.github.com/v3/pulls/ |
There was a problem hiding this comment.
| * | ||
| * @param string $username the username | ||
| * @param string $repository the repository | ||
| * @param array $pullRequest the pull request number |
| * | ||
| * @param string $username the username | ||
| * @param string $repository the repository | ||
| * @param array $pullRequest the pull request number |
| * | ||
| * @param string $username the username | ||
| * @param string $repository the repository | ||
| * @param array $pullRequest the pull request number |
| /** | ||
| * Submit a pull request review by the username, repository, pull request number and the review id. | ||
| * | ||
| * @link http://developer.github.com/v3/pulls/ |
There was a problem hiding this comment.
| * | ||
| * @param string $username the username | ||
| * @param string $repository the repository | ||
| * @param array $pullRequest the pull request number |
| /** | ||
| * Dismiss a pull request review by the username, repository, pull request number and the review id. | ||
| * | ||
| * @link http://developer.github.com/v3/pulls/ |
There was a problem hiding this comment.
| * | ||
| * @param string $username the username | ||
| * @param string $repository the repository | ||
| * @param array $pullRequest the pull request number |
Oh no, that was not intended, but just an oversight. I'll look into it tonight. |
|
I changed the |
|
There is still one bug (I think), changing the headers doesn't reset the HttpClient with |
No description provided.