GraphQL API

[m1guelpf]

Add support for the Github GraphQL API.

[cursedcoder]

1 space line before namespace tag is required

[m1guelpf]

@cursedcoder Done!

[xabbuh]

Shouldn't this be https://developer.github.com/early-access/graphql/?

[Nyholm]

Yes, it should

[Nyholm]

Where can I find documentation about the endpoint? These docs just explain parameters.

Also, may you add a simple test?

[Nyholm]

Yes, it should

[Nyholm]

Should be mention that this is the Early Access program?

[m1guelpf]

Done

[m1guelpf]

@Nyholm I keep having the same problem with the tests. I don't know how the fake data is generated, so I cannot add simple GraphQL data.
Maybe you should add that to the test docs.

[Nyholm]

Do we want the signature to be:
$github->graphql()->graphql($query)

Compare to:
$github->graphql()->execute($query)

[m1guelpf]

Do you want me to change it?

[Nyholm]

What do you think? What does @cursedcoder think?

[m1guelpf]

I think execute() is more clear.

[m1guelpf]

@Nyholm Changed.

[Nyholm]

This test would work (I've not run it)

class GraphQLTest extends TestCase
{
    // ...

    /**
     * @test
     */
    public function shouldShowGistComment()
    {
        $api = $this->getApiMock();

        $api->expects($this->once())
            ->method('post')
            ->with('/graphql', 'bar')
            ->will($this->returnValue('foo'));

        $result = $api-> graphql('bar');
        $this->assertEquals('foo', $result);
    }

    protected function getApiClass()
    {
        return \Github\Api\GraphQL::class;
    }
}

[m1guelpf]

@Nyholm Added Test.

[m1guelpf]

@Nyholm Changed function name.

[Nyholm]

copy/pate typo

[m1guelpf]

What typo?

[Nyholm]

This file should have class comment and namespace

[m1guelpf]

Done (I think)

[Nyholm]

Update this method name.

[m1guelpf]

Done

[Nyholm]

Should be an extra space before this line.

[m1guelpf]

Done

[Nyholm]

Remove this space.

[Nyholm]

Sorry, I missed that you are building an array.

->with($this->equalTo('/graphql'), $this->equalTo(['query'=>'bar']))

[m1guelpf]

@Nyholm Fixed.

[Nyholm]

Awesome. Thank you!

[m1guelpf]

@Nyholm @cursedcoder Merge?

[Nyholm]

Im 👍 to merge. But since other collaborators were involved here I would like to give them some time to review the changes as well.

[cursedcoder]

@xabbuh what would you say?

[cursedcoder]

Anyway merging this because we got 2/3 votes.