Fix "Body should be a JSON Array" issue #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…here adding labels to issues fails).
|
This fix is working for me too. I came here because of the regression to issue creation. |
|
Fix works for me, too. Please merge. |
|
Me too. Is this in a tag yet? |
|
Might be a silly question, but how could it be relevant to test |
| @@ -168,7 +168,7 @@ public function request($path, array $parameters = array(), $httpMethod = 'GET', | |||
| $request = $this->createRequest($httpMethod, $path); | |||
| $request->addHeaders($headers); | |||
| if (count($parameters) > 0) { | |||
| $request->setContent(json_encode($parameters, JSON_FORCE_OBJECT)); | |||
| $request->setContent(json_encode($parameters, empty($parameters)? JSON_FORCE_OBJECT : 0)); | |||
There was a problem hiding this comment.
add space before "?" please empty($parameters)? JSON_FORCE_OBJECT
|
@gquemener it's correct here, just wait @InventisPMTest to apply CS fix before merge |
pilot
added a commit
that referenced
this pull request
Sep 13, 2013
Fix "Body should be a JSON Array" issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request http://github.com/KnpLabs/php-github-api/pull/40 fixed some issues with empty parameters, but caused a regression on other functionalities (see URL for a more detailed explanation).
This modification only forces JSON-objects to be generated when the parameters are empty. This should fix the newly created issues as well as not regress the fix for the previous issue.