update php-http/client-common version constraint #443
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dependencies before could not have been resolved. Thus, it was not possible to run the test suite at all.
|
I want to do php-http/client-common#47 and then tag 1.3.0 ASAP. |
|
ping @GrahamCampbell I saw that you were the one bumping the requirements in #434. Was there a special reason for this? |
|
I did write:
Indicating that the PR was only valid following a tag on that library.
Yes, it guaranteed the cache bugfix would be present so that I could merge GrahamCampbell/Laravel-GitHub#40. |
|
I don't think this PR needs merging tbh. This library is still installable using the prefer stable system in composer. |
|
I just tagged 1.3.0 of client-common. This PR should be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependencies before could not have been resolved. Thus, it was not
possible to run the test suite at all.