Use PSR6 cache #404
Merged
Use PSR6 cache #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param CacheItemPoolInterface $cache | ||
| */ | ||
| public function useCache(CacheItemPoolInterface $cachePool) | ||
| public function addCache(CacheItemPoolInterface $cachePool) | ||
| { | ||
| $this->removePlugin(Plugin\CachePlugin::class); |
There was a problem hiding this comment.
Maybe call the removeCache() method here?
There was a problem hiding this comment.
I was just a 10 seconds slower than you. It is added now
|
The removeCache() function will not work properly until #405 is merged. |
| @@ -18,10 +18,13 @@ | |||
| ], | |||
| "require": { | |||
| "php": "^5.5|^7.0", | |||
There was a problem hiding this comment.
We can probs fix the indentation here. :)
|
Looks good to go. 👍 |
|
Thank you for your reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes our caching layer an introduce PSR-6 cache instead.
(It feels great to make a PR like this. Remove 500 lines just to add 17) =)
This will fix #390
This is BC break so it should be done before we tag 2.0.