Add a showContents() method to Contents API #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not really sure about this TBH... Additionally I don't like the name, better would be one of those: Also, can you add some tests for this? Thanks! |
|
OK for Honestly this is quite a usefull method, as you want to retrieve the content of a file more often than its information (default behavior of the API). And it's totally free ;) |
| $file = $this->show($username, $repository, $path, $reference); | ||
|
|
||
| if (!isset($file['type']) || 'file' !== $file['type']) { | ||
| throw new \Exception(sprintf('Path "%s" is not a file.', $path)); |
There was a problem hiding this comment.
Please use library exceptions here & below, it makes easier when you use it in other projects. Also add @throws notes to phpdoc.
stloyd
added a commit
that referenced
this pull request
Mar 17, 2013
Add a showContents() method to Contents API
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not directly linked to Github API.
This is a very useful method to get the real contents of a file, without having to do a bunch of tests by hand.