[POC] [WIP] Abstract the HTTP Client by using HTTPlug

[gquemener]

No description provided.

[GrahamCampbell]

👎 for the idea from me.

[docteurklein]

@GrahamCampbell Thanks for the feedback :) Can you explain why ?

[GrahamCampbell]

I just feel that guzzle 5/6 does a good job by itself. I see no advantage to adding yet another library on top that might suffer the same upgrading problems to newer libraries that we already do.

[docteurklein]

@GrahamCampbell I understand, I feel the same. The problem we tried to solve with this is the fact we were bound to an old version of guzzle (~3.7 !) and the fact that guzzle tends to break quite often.
With guzzle hidden behind the PSR-7 abstraction, I hope we will have less problems with version transitions (I try to convince myself :) not sure yet another abstraction will help, let's see).

In addition, we will have the guzzle 5+ http cache plugin for free, which is very cool.
Our home made cache is kinda buggy apparently.

[Nyholm]

Httplug is an abstraction for any http client. Using an abstraction means that you decouple yourself from the implementation. This is the D in SOLID, dependency inversion principle.

We should not exclude users using Guzzle5 by require Guzzle6, right? If someone do not want to use Guzzle at all but pure cURL instead should we force them to do otherwise? No. Authors of KnpLabs/php-github-api are experts on the GitHub API and they should not reinvent the wheel with send http messages.

I have made some contributions to the php-http organisation and I am happy to help migrating KnpLabs/php-github-api to Httplug.

[cursedcoder]

@Nyholm you may fork this PR if you are interested.
For now I'm closing it as it's not going to be finished.

[Nyholm]

@cursedcoder Are you interested in this feature if I finish the PR?

[cursedcoder]

@Nyholm it would be great if you can finish it.

[Nyholm]

Thank you. I'll add this on my TODO list =)

[Nyholm]

I forgot to ping this thread. Here are the new PR: #389