Mention search api in docs under Issues find() #302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -23,7 +23,7 @@ Returns an array of issues. | |||
| $issues = $client->api('issue')->find('KnpLabs', 'php-github-api', 'closed', 'bug'); | |||
| ``` | |||
|
|
|||
| Returns an array of closed issues matching the "bug" term. | |||
| Returns an array of closed issues matching the "bug" term. For more complex searches, use the [search api](/doc/search.md) which supports the advanced github search syntax. | |||
There was a problem hiding this comment.
please use relative links. It will be more reliable if the way to diplay the doc changes
There was a problem hiding this comment.
Did I add an absolute URL somewhere?
On Aug 5, 2015, at 9:48 AM, Christophe Coevoet notifications@github.com wrote:
In doc/issues.md:
@@ -23,7 +23,7 @@ Returns an array of issues.
$issues = $client->api('issue')->find('KnpLabs', 'php-github-api', 'closed', 'bug');-Returns an array of closed issues matching the "bug" term. +Returns an array of closed issues matching the "bug" term. For more complex searches, use the [search api](/doc/search.md) which supports the advanced github search syntax. please use relative links. It will be more reliable if the way to diplay the doc changes—
Reply to this email directly or view it on GitHub.
There was a problem hiding this comment.
@stof Oh I see what you're talking about. I'll fix it.
| @@ -23,7 +23,7 @@ Returns an array of issues. | |||
| $issues = $client->api('issue')->find('KnpLabs', 'php-github-api', 'closed', 'bug'); | |||
| ``` | |||
|
|
|||
| Returns an array of closed issues matching the "bug" term. | |||
| Returns an array of closed issues matching the "bug" term. For more complex searches, use the [search api](search.md) which supports the advanced github search syntax. | |||
There was a problem hiding this comment.
should be written GitHub imo
|
@xabbuh done |
cursedcoder
added a commit
that referenced
this pull request
Aug 6, 2015
Mention search api in docs under Issues find()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.