Added user suspension & un-suspension, resolves #207. #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given this is about Github Enterprise only, it is better to keep it in the Enterprise endpoint IMO |
|
As a developer, I'd expect a client to mirror the API it consumes as much as possible. If, in the GitHub documentation, this feature is associated with the User API, then I'd expect that to be reflected in the client. I concede that it makes sense to add it to the Enterprise API (not Enterprise endpoint... not sure how we would do that), but I think it should still exist as part of the User API. |
|
@stof I moved the methods in hopes of getting this change approved sooner. |
|
@pilot does this look good to you? |
|
Anything else I need to do to this? |
|
Can this be merged? |
|
One more time... any issues with this? |
pilot
added a commit
that referenced
this pull request
Feb 23, 2015
Added user suspension & un-suspension, resolves #207.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mdwheele I made changes similar to yours but added them to the User class.