added addSubscriber method because guzzle plugins are subscribers #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not just listeners
This was referenced Mar 19, 2014
| @@ -82,6 +82,11 @@ public function addListener($eventName, $listener) | |||
| $this->client->getEventDispatcher()->addListener($eventName, $listener); | |||
| } | |||
|
|
|||
| public function addSubscriber($subscriber) | |||
There was a problem hiding this comment.
this should be typehinted IMO
There was a problem hiding this comment.
I did not do it because of the typehint missing in the listener, should i do it, i think is reasonable
There was a problem hiding this comment.
a listener is a callable, which cannot be typehinted on PHP 5.3. A subscriber is an object implementing EventSubscriberInterface
|
done @stof Thanks, if not i will use my own fork on composer |
cursedcoder
added a commit
that referenced
this pull request
Mar 19, 2014
added addSubscriber method because guzzle plugins are subscribers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added addSubscriber method because guzzle plugins are subscribers