use ETag to decrease rate limit hits #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -43,6 +43,17 @@ public function set($id, Response $response) | |||
| if (false === @file_put_contents($this->getPath($id), serialize($response))) { | |||
| throw new \InvalidArgumentException(sprintf('Cannot put content in file "%s"', $this->getPath($id))); | |||
| } | |||
| if (false === @file_put_contents($this->getPath($id).'.etag', $response->getHeader('ETag'))) { | |||
cursedcoder
added a commit
that referenced
this pull request
Dec 23, 2013
use ETag to decrease rate limit hits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since a certain time, github doesn't seem to use date based http cache headers.
It seems however, that they look at etags.
this PR adds etag headers in addition to existing dates headers.