Skip to content

Missing header in /user/installations requests #882

Closed
@vovayatsyuk

Description

@vovayatsyuk

These two methods need a application/vnd.github.machine-man-preview+json header: https://github.com/KnpLabs/php-github-api/blob/master/lib/Github/Api/CurrentUser.php#L187-L206

Here is a new requirement:
https://developer.github.com/v3/apps/installations/#list-app-installations-accessible-to-the-user-access-token
https://developer.github.com/v3/apps/installations/#list-repositories-accessible-to-the-user-access-token

Note: To access the API with your GitHub App, you must provide a custom media type in the Accept Header for your requests.

application/vnd.github.machine-man-preview+json

I can create a PR and move the methods to Apps.php which already has a method to add required header, or I can copy AcceptHeaderTrait to the CurrentUser class.

How do you want to fix it?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions