Pass cluster cookie to workers as std input rather than on command line #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(oh and I did test this, I have a slurm job running across five nodes with the modified code now) |
|
Looks good to me. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This passes the cluster cookie as standard input to
srun, rather than as a--worker=<cookie>flag;srunthen forwards that stdin to the worker. This is the recommended/default behavior of addprocs; the--worker=<cookie>format was only added to support Windows workers that don't properly forward stdin. Since Slurm doesn't run on Windows this should be a non-issue.This improves security in shared cluster environments as the cookie is not available to other logged-in users through inspection of
ps -ef.