Put the entire test suite inside a top-level @testset
#34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kleinhenz This PR is ready for review now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes three changes:
@testset.@testset.@testset.When reviewing this PR, I recommend checking the "Hide whitespace" checkbox in the GitHub PR diff view. Otherwise, all the lines from change 3 above will clutter the diff, despite the fact that the only change on those lines is whitespace (indentation).
Motivation
Before this PR: if a single
@testfails, no subsequent tests will be run.After this PR: if a single
@testfails, the subsequent tests will still be run.