Skip to content

Fixes #1371 #1377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions src/main/java/net/sf/jsqlparser/expression/JsonFunction.java
Original file line number Diff line number Diff line change
Expand Up @@ -119,13 +119,14 @@ public StringBuilder append(StringBuilder builder) {
case OBJECT:
appendObject(builder);
break;
case POSTGRES_OBJECT:
appendPostgresObject(builder);
break;
case ARRAY:
appendArray(builder);
break;
default:
// this should never happen really
throw new UnsupportedOperationException("JSON Aggregate Function of the type "
+ functionType.name() + " has not been implemented yet.");
}
return builder;
}
Expand Down Expand Up @@ -184,6 +185,21 @@ public StringBuilder appendObject(StringBuilder builder) {
return builder;
}


@SuppressWarnings({"PMD.CyclomaticComplexity", "PMD.NPathComplexity"})
public StringBuilder appendPostgresObject(StringBuilder builder) {
builder.append("JSON_OBJECT( ");
for (JsonKeyValuePair keyValuePair : keyValuePairs) {
builder.append(keyValuePair.getKey());
if (keyValuePair.getValue()!=null) {
builder.append(", ").append(keyValuePair.getValue());
}
}
builder.append(" ) ");

return builder;
}

@SuppressWarnings({"PMD.CyclomaticComplexity", "PMD.NPathComplexity"})
public StringBuilder appendArray(StringBuilder builder) {
builder.append("JSON_ARRAY( ");
Expand All @@ -203,10 +219,10 @@ public StringBuilder appendArray(StringBuilder builder) {
builder.append(" NULL ON NULL ");
break;
case ABSENT:
builder.append(" ABSENT On NULL ");
builder.append(" ABSENT ON NULL ");
break;
default:
// "ON NULL" was ommitted
// "ON NULL" was omitted
}
}
builder.append(") ");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,5 @@
public enum JsonFunctionType {
OBJECT
, ARRAY
, POSTGRES_OBJECT
}
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public class JsonKeyValuePair {
public JsonKeyValuePair(String key, Object value, boolean usingKeyKeyword,
boolean usingValueKeyword) {
this.key = Objects.requireNonNull(key, "The KEY of the Pair must not be null");
this.value = Objects.requireNonNull(value, "The VALUE of the Pair must not be null");
this.value = value;
this.usingKeyKeyword = usingKeyKeyword;
this.usingValueKeyword = usingValueKeyword;
}
Expand Down
5 changes: 5 additions & 0 deletions src/main/java/net/sf/jsqlparser/parser/feature/Feature.java
Original file line number Diff line number Diff line change
Expand Up @@ -714,6 +714,11 @@ public enum Feature {
*/
allowSquareBracketQuotation(false),

/**
allow parsing of RDBMS specific syntax by switching off SQL Standard Compliant Syntax
*/
allowPostgresSpecificSyntax(false),

// PERFORMANCE

/**
Expand Down
42 changes: 29 additions & 13 deletions src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt
Original file line number Diff line number Diff line change
Expand Up @@ -3910,7 +3910,7 @@ JsonFunction JsonFunction() : {
boolean usingKeyKeyword = false;
boolean usingValueKeyword = false;
Token keyToken;
Token valueToken;
Token valueToken = null;
JsonKeyValuePair keyValuePair;

Expression expression;
Expand All @@ -3921,35 +3921,52 @@ JsonFunction JsonFunction() : {
(
(
( <K_JSON_OBJECT>
"(" { result.setType( JsonFunctionType.OBJECT ); }
"(" { result.setType( JsonFunctionType.OBJECT ); }

(
// --- First Element
[ "KEY" { usingKeyKeyword = true; } ]
( keyToken = <DT_ZONE> | keyToken = <S_DOUBLE> | keyToken = <S_LONG> | keyToken = <S_HEX> | keyToken = <S_CHAR_LITERAL> | keyToken = <S_IDENTIFIER> | keyToken = <S_QUOTED_IDENTIFIER> )
( ":" | "VALUE" { usingValueKeyword = true; } )
( valueToken = <S_IDENTIFIER> | valueToken = <S_QUOTED_IDENTIFIER> ) { keyValuePair = new JsonKeyValuePair( keyToken.image, valueToken.image, usingKeyKeyword, usingValueKeyword ); result.add(keyValuePair); }
LOOKAHEAD(2)
(
// Postgres Specific Syntax:
// SELECT json_object('{a, 1, b, 2}');
// SELECT json_object('{{a, 1}, {b, 2}}');
// SELECT json_object('{a, b}', '{1,2 }');
{ result.setType( JsonFunctionType.POSTGRES_OBJECT ); }
keyToken = <S_CHAR_LITERAL>
[ "," valueToken = <S_CHAR_LITERAL> ]
{ keyValuePair = new JsonKeyValuePair( keyToken.image, valueToken !=null ? valueToken.image : null, false, false ); result.add(keyValuePair); }
)
|
(

// SQL2016 compliant Syntax
[ "KEY" { usingKeyKeyword = true; } ]

( keyToken = <DT_ZONE> | keyToken = <S_DOUBLE> | keyToken = <S_LONG> | keyToken = <S_HEX> | keyToken = <S_CHAR_LITERAL> | keyToken = <S_IDENTIFIER> | keyToken = <S_QUOTED_IDENTIFIER> )
( ":" | "VALUE" { usingValueKeyword = true; } )
( valueToken = <S_IDENTIFIER> | valueToken = <S_QUOTED_IDENTIFIER> ) { keyValuePair = new JsonKeyValuePair( keyToken.image, valueToken.image, usingKeyKeyword, usingValueKeyword ); result.add(keyValuePair); }
)

[ <K_FORMAT> <K_JSON> { keyValuePair.setUsingFormatJson( true ); } ]

// --- Next Elements
( "," { usingKeyKeyword = false; usingValueKeyword = false; }
[ "KEY" { usingKeyKeyword = true; } ]
keyToken = <S_IDENTIFIER>
( ":" | "VALUE" { usingValueKeyword = true; } )
keyToken = <S_IDENTIFIER>
( ":" | "VALUE" { usingValueKeyword = true; } )
// token = <DT_ZONE> | <S_DOUBLE> | <S_LONG> | <S_HEX> | <S_CHAR_LITERAL> { result.setValue( token.image ); }
valueToken = <S_IDENTIFIER> { keyValuePair = new JsonKeyValuePair( keyToken.image, valueToken.image, usingKeyKeyword, usingValueKeyword ); result.add(keyValuePair); }

[ <K_FORMAT> <K_JSON> { keyValuePair.setUsingFormatJson( true ); } ]
)*
)*

[
(
[
(
<K_NULL> <K_ON> <K_NULL> { result.setOnNullType( JsonAggregateOnNullType.NULL ); }
)
|
(
(
<K_ABSENT> <K_ON> <K_NULL> { result.setOnNullType( JsonAggregateOnNullType.ABSENT ); }
)
]
Expand All @@ -3963,7 +3980,6 @@ JsonFunction JsonFunction() : {
<K_WITHOUT> <K_UNIQUE> <K_KEYS> { result.setUniqueKeysType( JsonAggregateUniqueKeysType.WITHOUT ); }
)
]

")"
)
|
Expand Down
36 changes: 36 additions & 0 deletions src/test/java/net/sf/jsqlparser/expression/JsonFunctionTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,10 @@
import java.util.Objects;
import junit.framework.Assert;
import net.sf.jsqlparser.JSQLParserException;
import net.sf.jsqlparser.parser.CCJSqlParserUtil;
import net.sf.jsqlparser.test.TestUtils;
import org.junit.Test;
import org.junit.jupiter.api.Assertions;

/**
*
Expand Down Expand Up @@ -138,6 +140,14 @@ public void testObject() throws JSQLParserException {
"SELECT JSON_OBJECT( KEY foo VALUE bar FORMAT JSON, foo:bar, foo:bar ABSENT ON NULL) FROM dual ",
true);

TestUtils.assertSqlCanBeParsedAndDeparsed(
"SELECT JSON_OBJECT( KEY foo VALUE bar FORMAT JSON, foo:bar, foo:bar ABSENT ON NULL WITH UNIQUE KEYS) FROM dual ",
true);

TestUtils.assertSqlCanBeParsedAndDeparsed(
"SELECT JSON_OBJECT( KEY foo VALUE bar FORMAT JSON, foo:bar, foo:bar ABSENT ON NULL WITHOUT UNIQUE KEYS) FROM dual ",
true);

TestUtils.assertExpressionCanBeParsedAndDeparsed("json_object(null on null)", true);

TestUtils.assertExpressionCanBeParsedAndDeparsed("json_object(absent on null)", true);
Expand Down Expand Up @@ -190,4 +200,30 @@ public void testIssue1260() throws JSQLParserException {
")\n" +
"from SYSIBM.DUAL", true);
}


@Test
public void testIssue1371() throws JSQLParserException {
TestUtils.assertSqlCanBeParsedAndDeparsed("SELECT json_object('{a, 1, b, 2}')", true);
TestUtils.assertSqlCanBeParsedAndDeparsed("SELECT json_object('{{a, 1}, {b, 2}}')", true);
TestUtils.assertSqlCanBeParsedAndDeparsed("SELECT json_object('{a, b}', '{1,2 }')", true);
}

@Test
public void testJavaMethods() throws JSQLParserException {
String expressionStr= "JSON_OBJECT( KEY foo VALUE bar FORMAT JSON, foo:bar, foo:bar ABSENT ON NULL WITHOUT UNIQUE KEYS)";
JsonFunction jsonFunction = (JsonFunction) CCJSqlParserUtil.parseExpression(expressionStr);

Assertions.assertEquals(JsonFunctionType.OBJECT, jsonFunction.getType());
Assertions.assertNotEquals(jsonFunction.withType(JsonFunctionType.POSTGRES_OBJECT), jsonFunction.getType());

Assertions.assertEquals(3, jsonFunction.getKeyValuePairs().size());
Assertions.assertEquals(new JsonKeyValuePair("foo", "bar", true, true), jsonFunction.getKeyValuePair(0));

jsonFunction.setOnNullType(JsonAggregateOnNullType.NULL);
Assertions.assertEquals(JsonAggregateOnNullType.ABSENT, jsonFunction.withOnNullType(JsonAggregateOnNullType.ABSENT).getOnNullType());

jsonFunction.setUniqueKeysType(JsonAggregateUniqueKeysType.WITH);
Assertions.assertEquals(JsonAggregateUniqueKeysType.WITH, jsonFunction.withUniqueKeysType(JsonAggregateUniqueKeysType.WITH).getUniqueKeysType());
}
}
16 changes: 5 additions & 11 deletions src/test/java/net/sf/jsqlparser/test/TestUtils.java
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ public static void assertOracleHintExists(String sql, boolean assertDeparser, St
OracleHint hint = ps.getOracleHint();
assertNotNull(hint);
assertEquals(hints[0], hint.getValue());
} else {
} else
if (stmt.getSelectBody() instanceof SetOperationList) {
SetOperationList setop = (SetOperationList) stmt.getSelectBody();
for (int i = 0; i < setop.getSelects().size(); i++) {
Expand All @@ -318,22 +318,16 @@ public static void assertOracleHintExists(String sql, boolean assertDeparser, St
}
}
}
}
} else if (statement instanceof Update) {
Update stmt = (Update) statement;
OracleHint hint = stmt.getOracleHint();
assertNotNull(hint);
assertEquals(hints[0], hint.getValue());
} else if (statement instanceof Insert) {
Insert stmt = (Insert) statement;
OracleHint hint = stmt.getOracleHint();
assertNotNull(hint);
assertEquals(hints[0], hint.getValue());
} else if (statement instanceof Update) {
Update stmt = (Update) statement;
OracleHint hint = stmt.getOracleHint();
assertNotNull(hint);
assertEquals(hints[0], hint.getValue());
Insert stmt = (Insert) statement;
OracleHint hint = stmt.getOracleHint();
assertNotNull(hint);
assertEquals(hints[0], hint.getValue());
} else if (statement instanceof Delete) {
Delete stmt = (Delete) statement;
OracleHint hint = stmt.getOracleHint();
Expand Down