Skip to content

Improve Travis CI build Performance #1307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Improve Travis CI build Performance #1307

wants to merge 2 commits into from

Conversation

chenzhang22
Copy link

Caching Dependencies and Directories Travis CI can cache content that does not often change, to speed up the build process.

=====================
If there are any inappropriate modifications in this PR, please give me a reply and I will change them.

@wumpz
Copy link
Member

wumpz commented Aug 25, 2021

Is this the problem you described building with java 8? However, improving performance is good.

@manticore-projects
Copy link
Contributor

Is this the problem you described building with java 8?

The CI test takes the Gradle build as default, where I have defined a minimum test coverage of 0.84 (which will be reported with Java 11).

For any reason, with Java 8 we achieve only 0.834.

Solution is to a) increase the Test Coverage (which I have done in the pending PR) and also b) to define the minimum coverage based on Java 8 (which I have done in the pending PR).

@chenzhang22
Copy link
Author

gradle can also be cached

manticore-projects added a commit to manticore-projects/JSqlParser that referenced this pull request Sep 7, 2021
@manticore-projects manticore-projects mentioned this pull request Sep 7, 2021
@manticore-projects
Copy link
Contributor

Thank you so much, I have incorporated your suggestions into PR #1329 -- but attributed all credits to you.
I chose this path when the Travis CI Test kept failing.

wumpz added a commit that referenced this pull request Sep 7, 2021
* Implement caching of the Gradle and Maven files
Provided by @YunLemon via PR #1307

* Fix CREATE TABLE AS SELECT ... UNION SELECT ...
Provided by @fanchuo via PR #1309

* Fix #1316
Add more specific tests verifying the nature of the UpdateSets
Allow "SELECT *" (without FROM) to parse, its a valid SELECT statement

* Add the enhancements since Release 4.1

* Adjust the Coverage

* Improve Test Coverage

* Revert the Special Oracle Tests (accidentally set to FAILURE)

Co-authored-by: Tobias <t.warneke@gmx.net>
@manticore-projects
Copy link
Contributor

@YunLemon: Your change has been merged into MASTER via PR #1329. Thank you again for the improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants