Skip to content

Allowes JdbcParameter or JdbcNamedParameter for MySQL FullTextSearch #1278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,16 @@
import java.util.Optional;
import net.sf.jsqlparser.expression.Expression;
import net.sf.jsqlparser.expression.ExpressionVisitor;
import net.sf.jsqlparser.expression.JdbcNamedParameter;
import net.sf.jsqlparser.expression.JdbcParameter;
import net.sf.jsqlparser.expression.StringValue;
import net.sf.jsqlparser.parser.ASTNodeAccessImpl;
import net.sf.jsqlparser.schema.Column;

public class FullTextSearch extends ASTNodeAccessImpl implements Expression {

private List<Column> _matchColumns;
private StringValue _againstValue;
private Expression _againstValue;
private String _searchModifier;

public FullTextSearch() {
Expand All @@ -42,8 +44,16 @@ public List<Column> getMatchColumns() {
public void setAgainstValue(StringValue val) {
this._againstValue = val;
}

public void setAgainstValue(JdbcNamedParameter val) {
this._againstValue = val;
}

public void setAgainstValue(JdbcParameter val) {
this._againstValue = val;
}

public StringValue getAgainstValue() {
public Expression getAgainstValue() {
return this._againstValue;
}

Expand Down
29 changes: 19 additions & 10 deletions src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt
Original file line number Diff line number Diff line change
Expand Up @@ -4149,22 +4149,31 @@ FullTextSearch FullTextSearch() : {
Column col;
Token searchModifier;
Token againstValue;
JdbcParameter jdbcParameter;
JdbcNamedParameter jdbcNamedParameter;
FullTextSearch fs = new FullTextSearch();
List<Column> matchedColumns = new ArrayList<Column>();
List<Expression> expList = new ArrayList<Expression>();
}
{
<K_MATCH> "(" col=Column() { matchedColumns.add(col); } ("," col=Column() { matchedColumns.add(col); } )* ")" <K_AGAINST>
"(" againstValue=<S_CHAR_LITERAL> { fs.setAgainstValue(new StringValue(againstValue.image)); }
[
(
searchModifier="IN NATURAL LANGUAGE MODE"
| searchModifier="IN NATURAL LANGUAGE MODE WITH QUERY EXPANSION"
| searchModifier="IN BOOLEAN MODE"
| searchModifier="WITH QUERY EXPANSION"
)
{ fs.setSearchModifier(searchModifier.image); }
]
"("
(
againstValue=<S_CHAR_LITERAL> { fs.setAgainstValue(new StringValue(againstValue.image)); }
|
jdbcParameter=SimpleJdbcParameter() { fs.setAgainstValue( jdbcParameter ); }
|
jdbcNamedParameter=SimpleJdbcNamedParameter() { fs.setAgainstValue( jdbcNamedParameter ); }
)
[
(
searchModifier="IN NATURAL LANGUAGE MODE"
| searchModifier="IN NATURAL LANGUAGE MODE WITH QUERY EXPANSION"
| searchModifier="IN BOOLEAN MODE"
| searchModifier="WITH QUERY EXPANSION"
)
{ fs.setSearchModifier(searchModifier.image); }
]
")"
{
fs.setMatchColumns(matchedColumns);
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
/*-
* #%L
* JSQLParser library
* %%
* Copyright (C) 2004 - 2021 JSQLParser
* %%
* Dual licensed under GNU LGPL 2.1 or Apache License 2.0
* #L%
*/

package net.sf.jsqlparser.expression.operators.relational;

import net.sf.jsqlparser.JSQLParserException;
import net.sf.jsqlparser.test.TestUtils;
import org.junit.Test;

/**
*
* @author <a href="mailto:andreas@manticore-projects.com">Andreas Reichel</a>
*/
public class FullTextSearchExpressionTest {
@Test
public void testFullTextSearchExpressionWithParameters() throws JSQLParserException {
TestUtils.assertSqlCanBeParsedAndDeparsed(
"select match (name) against (?) as full_text from commodity", true);
TestUtils.assertSqlCanBeParsedAndDeparsed(
"select match (name) against (:parameter) as full_text from commodity", true);
}

@Test
public void testIssue1223() throws JSQLParserException {
TestUtils.assertSqlCanBeParsedAndDeparsed("select\n" + "c.*,\n"
+ "match (name) against (?) as full_text\n" + "from\n" + "commodity c\n" + "where\n"
+ "match (name) against (?)\n" + "and c.deleted = 0\n" + "order by\n" + "full_text desc",
true);
}
}