Skip to content

Added Enable/Disable All and the option to select a root directory for relative paths #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

justo46
Copy link
Contributor

@justo46 justo46 commented Mar 13, 2023

No description provided.

@losanc
Copy link
Contributor

losanc commented Mar 19, 2023

Hi,

thanks for the PR! some questions

  1. Is root_path assigned to each object, or only assigned to each scene?

    For example, property relative is used for both scene and object. scene.relative is used as a setting when you load the object, after loading it, obj.relative is used for this individual object. And currently it's always relative to the path of .blend file.

    I see your code root_path is only for each scene. So, for example, if I load a sequence with root_path = "pathA", then I maybe misclicked then change the root_path to PathB, or maybe load a new sequence with using root_path="pathB"
    , then all loaded sequences will become invalid.

root_path: bpy.props.StringProperty(name="Root Directory",
                                        subtype="DIR_PATH",
                                        description="Select a root folder for all relative paths. When not set the current filename is used.",
                                        update=update_path)

you probably don't need update=update_path here

@digitalillusions
Copy link
Member

I think the idea was to keep this as a global setting. The main motivation is provide an alternate source for relative paths, in the case that the relative location of the .blend file is different on different machines. As such, being able to specify a global root directory allows you to remap all sequences using a relative path with a single action.

I think using a different root dir for individual sequences is hardly any different from just using absolute paths for each sequence, since they would have to be remapped anyway, and it also adds a lot more

@digitalillusions
Copy link
Member

Thanks! Looks good to me now.

@digitalillusions digitalillusions merged commit 88c89c4 into InteractiveComputerGraphics:main Mar 25, 2023
@justo46 justo46 deleted the enable_dsiable_all_root branch May 22, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants