Skip to content

Refactor code #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 42 commits into from
Oct 5, 2021
Merged

Refactor code #97

merged 42 commits into from
Oct 5, 2021

Conversation

LyndonFan
Copy link
Contributor

Addresses most issues in #95

  • Fixed 2 instances of unnecessary else
  • Fixed 2 instances of using range(len(...))
  • Fixed 1 instance of code complexity by removing unnecessary "is not None" check
  • Fixed 1 instance of code security by using requests.get instead of urllib.request.urlretrieve

There is still 1 instance of code complexity issue remaining. I have performed some minor refactoring, but it's still too complex according to codefactor.io.

@LyndonFan
Copy link
Contributor Author

The new code has passed all the checks. Would it be possible to get a review?

Copy link
Contributor

@Alexsandruss Alexsandruss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no problems, let's wait for at least one additional approve.

@napetrov napetrov merged commit 813cca5 into IntelPython:master Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants