Skip to content

Add metrics testing #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Aug 17, 2021
Merged

Add metrics testing #87

merged 24 commits into from
Aug 17, 2021

Conversation

OnlyDeniko
Copy link
Contributor

No description provided.

@OnlyDeniko OnlyDeniko marked this pull request as ready for review August 12, 2021 09:27
@OnlyDeniko OnlyDeniko requested a review from outoftardis August 12, 2021 09:28
@OnlyDeniko OnlyDeniko added enhancement New feature or request extend Extend benchmarks labels Aug 12, 2021
RukhovichIV
RukhovichIV reviewed Aug 12, 2021
View reviewed changes
outoftardis
outoftardis reviewed Aug 12, 2021
View reviewed changes
OnlyDeniko and others added 7 commits August 12, 2021 14:22
@OnlyDeniko
apply comments, part1
b9babf4
@OnlyDeniko
apply comments, part2
618e7c4
@OnlyDeniko
dfs strategy to take jsons from folders
57dd110
@OnlyDeniko
now you can --configs=folder,.json,folder
4a21cd8
@OnlyDeniko @outoftardis
Update README.md
e4d6f94 
Co-authored-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
@OnlyDeniko @outoftardis
Update sklearn_bench/knn_regr.py
6a126d8 
Co-authored-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
@OnlyDeniko @outoftardis
Update runner.py
ecb8938 
Co-authored-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
Alexsandruss
Alexsandruss reviewed Aug 13, 2021
View reviewed changes
Copy link
Contributor

@Alexsandruss Alexsandruss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why so many configs were added?
For future: add at least minimal description for PR

RukhovichIV
RukhovichIV approved these changes Aug 13, 2021
View reviewed changes
Copy link

@RukhovichIV RukhovichIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The appearance looks good to me, thanks!
I'm not competent enough about the content (of sklearn workloads), but looks like ok 👍

@RukhovichIV
Copy link

Since the PR is huge, I'd recommend to wait for, at least, 3 approvals :)

@OnlyDeniko
Copy link
Contributor Author

@Alexsandruss

Why so many configs were added?
For future: add at least minimal description for PR

We would like to add testing of metrics for all optimized algorithms with parameters specialized for each dataset, so we get such a large amount of configs

@OnlyDeniko OnlyDeniko merged commit 33c95a6 into IntelPython:master Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RukhovichIV RukhovichIV RukhovichIV approved these changes

@outoftardis outoftardis outoftardis approved these changes

@Alexsandruss Alexsandruss Alexsandruss approved these changes

@PetrovKP PetrovKP Awaiting requested review from PetrovKP

Assignees
No one assigned
Labels
enhancement New feature or request extend Extend benchmarks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OnlyDeniko @RukhovichIV @outoftardis @Alexsandruss