Skip to content

Refactoring of report generator #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Aug 11, 2021
Merged

Refactoring of report generator #84

merged 17 commits into from
Aug 11, 2021

Conversation

OnlyDeniko
Copy link
Contributor

No description provided.

@OnlyDeniko OnlyDeniko marked this pull request as ready for review August 4, 2021 11:06
@PetrovKP PetrovKP added the enhancement New feature or request label Aug 4, 2021
PetrovKP
PetrovKP reviewed Aug 4, 2021
View reviewed changes
Alexsandruss
Alexsandruss requested changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@Alexsandruss Alexsandruss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove empty columns like input_data:classes in kmeans sheet.

@OnlyDeniko
Copy link
Contributor Author

OnlyDeniko commented Aug 5, 2021 •
edited
Loading

Remove empty columns like input_data:classes in kmeans sheet.

Really good idea, thank you. Now if report does not have some parameters from config['header'] then they will not be shown.

outoftardis
outoftardis reviewed Aug 6, 2021
View reviewed changes
OnlyDeniko and others added 2 commits August 6, 2021 11:49
@OnlyDeniko @outoftardis
Update report_generator/README.md
ef4849e 
Co-authored-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
@OnlyDeniko @outoftardis
Update report_generator/README.md
cf481fc 
Co-authored-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
outoftardis
outoftardis reviewed Aug 6, 2021
View reviewed changes
@OnlyDeniko @outoftardis
Update report_generator/README.md
0135bd5 
Co-authored-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
outoftardis
outoftardis reviewed Aug 11, 2021
View reviewed changes
@OnlyDeniko @outoftardis
Update sklearn_bench/pca.py
9f59119 
Co-authored-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
@OnlyDeniko OnlyDeniko merged commit 556313d into IntelPython:master Aug 11, 2021
@OnlyDeniko OnlyDeniko deleted the report_generator branch August 11, 2021 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PetrovKP PetrovKP PetrovKP left review comments

@outoftardis outoftardis outoftardis approved these changes

@RukhovichIV RukhovichIV RukhovichIV approved these changes

@Alexsandruss Alexsandruss Alexsandruss approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@OnlyDeniko @RukhovichIV @PetrovKP @outoftardis @Alexsandruss