-
Notifications
You must be signed in to change notification settings - Fork 73
Xgb datasets adding #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Alexsandruss
merged 39 commits into
IntelPython:master
from
RukhovichIV:xgb-nvidia-datasets
Apr 26, 2021
Merged
Changes from 37 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
62f87c3
Applied mypy + flake8 for all files
132d73f
Sorted imports with ISort
4aa4898
Moved env change to runner
5a8db33
fixed all mypy errors and added mypy check to CI
5594efd
Yet another mypy fixes
35b55b8
Small runner refactoring
56de8f7
First attempt of adding nvidia datasets
0ee5f05
Merge branch 'master' into mypy-applying
04e7a64
removed E265 ignoring for flake8 job
8268747
Merge remote-tracking branch 'my/mypy-applying' into xgb-nvidia-datasets
b6a7eb0
NVidia benchmarks are working now
7e780bb
Added higgs, msrank and airline fetching
670c289
small fixes of env
dc0e9c9
Applying comments
f64ae68
Merge branch 'mypy-applying' into xgb-nvidia-datasets
873754b
Split dataset loading to different files
93ea32d
Merge remote-tracking branch 'origin/master' into xgb-nvidia-datasets
dcfc5b9
Why doesnt mypy work?
340402e
Added abalone + letters, updated all GB configs
6e47423
Added links and descriptions for new datasets
340a628
Merge remote-tracking branch 'origin/master' into xgb-nvidia-datasets
4be3720
handling mypy
8184016
Handled skex fake message throwing
cf5ee76
Trying to handle mypy, at. 3
9db3177
Trying to handle mypy, at. 4
5e76a0b
Trying to handle mypy, at. 5
13fcd20
Changed configs readme and made small fixes in GB testing configs
0873f97
Merge branch 'master' of https://github.com/IntelPython/scikit-learn_…
877e0fd
Applying more comments, updating readme's
8bdc7f2
Applying comments: renamed configs
f9cf09b
Changed all datasets to npy, applied Kirill's comments
41e003f
Merge branch 'master' of https://github.com/IntelPython/scikit-learn_…
523df30
Cleanup after someone's commit
59303fa
Applying mypy
b56e42c
Applied Ekaterina's suggestions
ad176e5
Applied other Ekaterina's comments
b92a27f
Merge branch 'xgb-nvidia-datasets' of https://github.com/RukhovichIV/…
11a8ffc
Final commits applying
37d5461
Alexander's final comments
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not clear why only first stage has
alg_params
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like in all benchmarks all stages in each case has similar parameters. So, since the the parameter list is usually quite long, we can reduce the length of benchmark output by printing this section only once.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RukhovichIV, Excel report generator filters benchmark cases basing on parameters, output should not be shortened for correct work of generator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rolled back that change, but very upset about it :(