Feature/tls dfti cache #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced use of global variable to store cached DFTI descriptor in favor of using Thread Local Storage to store it.
Since DftiCache is allocated in thread local storage, use of Lock() is not longer needed.
|
Wow, that's a lot of changes. Well I don't see anything nasty in there, and the CI passed. I imagine you also did some testing so assuming that you didn't encounter any issues, this should be good to merge. 👍 |
anton-malakhov
approved these changes
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces use of global variable used to cache dfti descriptor (and required use of
threading.Lock()to protect it from corruption in multi-threaded use) with use of thread local storage.Consequentially, this removes the need to use
atexitto register cache destructor. Use ofDftiFreeDescriptorin the function registered withatexitmay cause a crash (like it did on Windows), since the library can not be guaranteed to still be loaded.