Skip to content

No need to extract dpnp conda package in GitHub actions #2282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jan 27, 2025

Now it is not required to extract dpnp conda package to run the test scope, because the tests will be installed during the conda package installation and so can be run with pytest -ra --pyargs dpnp.tests command.

The PR propose to remove obsolete steps from Conda package workflow.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

It is not more required to run the test scope, becuase now the tests are
installed during conda package installation and can be run with `pytest
-ra --pyargs dpnp.tests` command.
@antonwolfy antonwolfy self-assigned this Jan 27, 2025
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 71.275%. remained the same
when pulling 02f27a8 on remove-pkg-extraction-in-gh-actions
into bd0b5b0 on master.

Copy link
Contributor

Array API standard conformance tests for dpnp=0.17.0dev5=py312he4f9c94_5 ran successfully.
Passed: 956
Failed: 1
Skipped: 43

@antonwolfy antonwolfy marked this pull request as ready for review January 27, 2025 13:57
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you @antonwolfy

@antonwolfy antonwolfy merged commit d509d3f into master Jan 27, 2025
60 of 69 checks passed
@antonwolfy antonwolfy deleted the remove-pkg-extraction-in-gh-actions branch January 27, 2025 14:08
github-actions bot added a commit that referenced this pull request Jan 27, 2025
Now it is not required to extract dpnp conda package to run the test
scope, because the tests will be installed during the conda package
installation and so can be run with `pytest -ra --pyargs dpnp.tests`
command.

The PR propose to remove obsolete steps from `Conda package` workflow. d509d3f
antonwolfy added a commit that referenced this pull request Jan 27, 2025
Now it is not required to extract dpnp conda package to run the test
scope, because the tests will be installed during the conda package
installation and so can be run with `pytest -ra --pyargs dpnp.tests`
command.

The PR propose to remove obsolete steps from `Conda package` workflow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants