Skip to content

Support python 3.13 #2249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 9, 2025
Merged

Support python 3.13 #2249

merged 7 commits into from
Jan 9, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jan 7, 2025

The PR proposes to build and test with Python 3.13 in conda package workflow.

Also default python version used by other GH actions is bumped up to 3.13 except:

  • building docs because there is no support of python 3.13 in CuPy
  • coverage because there is no support of python 3.13 in coveralls

Note, conda-build does not support python 3.13, but it is still possible to install it into env with python 3.12 and to run conda build with --python 3.13 option.

Also it forces to pin numpy >= 1.23 in meta.yaml otherwise it is impossible to use the latest numpy version, because it is pinned to 2.0 by --numpy 2.0 option (while numpy 2.0 does not support python 3.13 yet, it has been added later).

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Jan 7, 2025
@antonwolfy antonwolfy force-pushed the support-python-3.13 branch from 2f3e41d to 645ed80 Compare January 7, 2025 15:34
Copy link
Contributor

github-actions bot commented Jan 7, 2025

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy force-pushed the support-python-3.13 branch 4 times, most recently from e8f80ee to 9edb460 Compare January 7, 2025 19:47
@antonwolfy antonwolfy force-pushed the support-python-3.13 branch from 9edb460 to a131bb2 Compare January 7, 2025 20:48
@coveralls
Copy link
Collaborator

coveralls commented Jan 7, 2025

Coverage Status

coverage: 65.08%. remained the same
when pulling 0b6ef1d on support-python-3.13
into 8d7ed21 on master.

@antonwolfy antonwolfy marked this pull request as ready for review January 8, 2025 12:29
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
Thank you @antonwolfy !

@antonwolfy antonwolfy merged commit 1bed3bd into master Jan 9, 2025
56 of 57 checks passed
@antonwolfy antonwolfy deleted the support-python-3.13 branch January 9, 2025 15:56
github-actions bot added a commit that referenced this pull request Jan 9, 2025
The PR proposes to build and test with Python 3.13 in conda package
workflow.

Also default python version used by other GH actions is bumped up to
3.13 except:
- building docs because there is no support of python 3.13 in CuPy
- coverage because there is no support of python 3.13 in `coveralls`

Note, `conda-build` does not support python 3.13, but it is still
possible to install it into env with python 3.12 and to run conda build
with `--python 3.13` option.

Also it forces to pin `numpy >= 1.23` in `meta.yaml` otherwise it is
impossible to use the latest numpy version, because it is pinned to 2.0
by `--numpy 2.0` option (while numpy 2.0 does not support python 3.13
yet, it has been added later). 1bed3bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants