Add order agrument to generate_random_numpy_array()
#2237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlad-perevezentsev
requested review from
antonwolfy,
AlexanderKalistratov and
vtavana
as code owners
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
reviewed
Dec 16, 2024
antonwolfy
approved these changes
Dec 16, 2024
vlad-perevezentsev
changed the title
order agrument to generate_random_numpy_array()
github-actions bot
added a commit
that referenced
this pull request
Dec 17, 2024
This PR suggests updating the helper function `generate_random_numpy_array()` by adding an argument `order` to generate arrays in different orders Additionally Input generation for tests was changed in #2227 , now `test_fft2` and `test_fftn` do not use `order` parameter. This PR suggests to update these tests to use input data with different orders. 8f05542
vtavana
pushed a commit
that referenced
this pull request
Dec 17, 2024
This PR suggests updating the helper function `generate_random_numpy_array()` by adding an argument `order` to generate arrays in different orders Additionally Input generation for tests was changed in #2227 , now `test_fft2` and `test_fftn` do not use `order` parameter. This PR suggests to update these tests to use input data with different orders.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suggests updating the helper function
generate_random_numpy_array()by adding an argumentorderto generate arrays in different ordersAdditionally
Input generation for tests was changed in #2227 , now
test_fft2andtest_fftndo not useorderparameter.This PR suggests to update these tests to use input data with different orders