Skip to content

Bump DPC++ compiler min version required for proper work of sycl::cyl_bessel_i0() #2186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Nov 19, 2024

DPC++ compiler released 2025.0.1 version where __SYCL_COMPILER_VERSION is defined to 20241113. But the fix for sycl::ext::intel::math::cyl_bessel_i0(x) support wasn't mapped there.

Thus the PR proposes to bump __SYCL_COMPILER_BESSEL_I0_SUPPORT define up to 20241114 value to exclude DPC++ compiler 2025.0.1 version.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy changed the title Bump DPC++ compiler version required for sycl::cyl_bessel_i0() proper work Bump DPC++ compiler min version required for proper work of sycl::cyl_bessel_i0() Nov 19, 2024
Copy link
Contributor

github-actions bot commented Nov 19, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy merged commit 488bdb5 into master Nov 19, 2024
44 of 46 checks passed
@antonwolfy antonwolfy deleted the bump-sycl-compiler-version-required-for-i0 branch November 19, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants