Skip to content

Skip test_solve with 3D matrix for numpy 2.0 #2126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Skip test_solve with 3D matrix for numpy 2.0 #2126

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8258cf
Update test_solve in test_sycl_queue
vlad-perevezentsev Oct 25, 2024
386bd2f
Merge branch 'master' into mute_solve_test
antonwolfy Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions tests/test_sycl_queue.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2251,8 +2251,13 @@ def test_solve(matrix, vector, device):
a_dp = dpnp.array(a_np, device=device)
b_dp = dpnp.array(b_np, device=device)

if a_dp.ndim > 2 and a_dp.device.sycl_device.is_cpu:
pytest.skip("SAT-6842: reported hanging in public CI")
# In numpy 2.0 the broadcast ambiguity has been removed and now
# b is treaded as a single vector if and only if it is 1-dimensional;
# for other cases this signature must be followed
# (..., m, m), (..., m, n) -> (..., m, n)
# https://github.com/numpy/numpy/pull/25914
if a_dp.ndim > 2 and numpy.lib.NumpyVersion(numpy.__version__) >= "2.0.0":
pytest.skip("SAT-6928")

result = dpnp.linalg.solve(a_dp, b_dp)
expected = numpy.linalg.solve(a_np, b_np)
Expand Down
Loading