update tests for dpnp.fft.irfft and dpnp.fft.hfft
#1958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
vtavana
force-pushed
the
unmute_rfft_tests
branch
from
88d11b3 to
5fb850e
Compare
vtavana
changed the title
dpnp.fft.irfftdpnp.fft.irfft and dpnp.fft.hfft
vtavana
force-pushed
the
unmute_rfft_tests
branch
from
5fb850e to
88030f5
Compare
antonwolfy
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Thank you @vtavana , I have only minor comment, but in general LGTM!
github-actions bot
added a commit
that referenced
this pull request
Aug 5, 2024
* unmute tests * reverse unintended changes * address comment --------- Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> d353299
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, tests for
dpnp.fft.irfftanddpnp.fft.hfft(which calls backdpnp.fft.irfft) are updated to make sure input array is Hermitian. This means that for 1-D array 0th element of the array has zero imaginary part. In addition, if output array size is N and N is even, the N/2-th element (N/2+1 frequency point) of input (Nyquist mode) also has zero imaginary part.