Skip to content

Remove a temporary workaround in GitHub actions #1761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 28, 2024
Merged

Remove a temporary workaround in GitHub actions #1761

merged 2 commits into from
Mar 28, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Mar 27, 2024 •
edited
Loading

Since 2024.1 is published on intel channel, which contains the required fixes, there is no need to keep the workarounds with pinning of DPC++ compiler to older versions (see #1628 and #1643 for more details).

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Mar 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 27, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html

vlad-perevezentsev
vlad-perevezentsev approved these changes Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you @antonwolfy

@antonwolfy antonwolfy merged commit c06e457 into master Mar 28, 2024
@antonwolfy antonwolfy deleted the remove-wa-for-gh-actions branch March 28, 2024 10:51
github-actions bot added a commit to antonwolfy/dpnp that referenced this pull request Mar 28, 2024
@github-actions
Remove a temporary workaround in GitHub actions (IntelPython#1761)
4a054c7 
* Remove temporary workaround in GH actions

* Keep dpctl pinning c06e457
@antonwolfy antonwolfy mentioned this pull request Apr 2, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vlad-perevezentsev