Skip to content

implement dpnp.reciprocal and dpnp.angle #1650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 20, 2024
Merged

implement dpnp.reciprocal and dpnp.angle #1650

merged 10 commits into from
Jan 20, 2024

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Jan 5, 2024

In this PR, dpnp.angle and dpnp.reciprocal are implemented using their dpctl counterparts.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Jan 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 5, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html

@vtavana vtavana marked this pull request as ready for review January 6, 2024 03:13
@vtavana vtavana requested a review from antonwolfy January 6, 2024 03:13
antonwolfy
antonwolfy reviewed Jan 9, 2024
View reviewed changes
vtavana
vtavana commented Jan 9, 2024
View reviewed changes
antonwolfy
antonwolfy reviewed Jan 9, 2024
View reviewed changes
antonwolfy
antonwolfy approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana !

@antonwolfy
Copy link
Contributor

antonwolfy commented Jan 10, 2024 •
edited
Loading

But to be able to merge the PR we need to wait until the latest dpctl will be available in the internal channel, otherwise the tests in the internal CI will be always failing.

vtavana and others added 8 commits January 17, 2024 11:20
@vtavana
implement dpnp.reciprocal and dpnp.angle
8dae602
@vtavana
fix docstring
a58f76c
@vtavana
skip umath test for reciprocal
da11aa7
@vtavana
address comments
14eee49
@vtavana
add a note for reciprocal
a6b5c05
@vtavana @antonwolfy
Update dpnp/dpnp_iface_trigonometric.py
a6d8580 
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
@vtavana
fix docstring
2e59ee9
@vtavana
update retunrs for angle and reciprocal
98edb71 
update out keyword implementation for angle and reciprocal to make it
consistent with implementation of other functions
@antonwolfy antonwolfy merged commit b401ae9 into master Jan 20, 2024
@antonwolfy antonwolfy deleted the reciprocal_angle branch January 20, 2024 17:32
@antonwolfy antonwolfy mentioned this pull request Feb 1, 2024
Merged
@antonwolfy antonwolfy mentioned this pull request May 31, 2024
Open
99 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndgrigorian ndgrigorian ndgrigorian left review comments

@antonwolfy antonwolfy antonwolfy approved these changes

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vtavana @antonwolfy @ndgrigorian