Skip to content

Redesign dpnp.diff thorough existing calls #1637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 7, 2023
Merged

Redesign dpnp.diff thorough existing calls #1637

merged 7 commits into from
Dec 7, 2023

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Dec 5, 2023 •
edited
Loading

The PR proposes to implement dpnp.diff function through existing dpnp python API. While the previous implementation of dpnp.diff was done through cython and has limited support of input arguments.

The PR assumes to get rid of all the limitations and to align with numpy implementation of diff function.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Dec 5, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html

Base automatically changed from put_take_along_axis to master December 6, 2023 17:47
@antonwolfy antonwolfy requested review from vtavana and vlad-perevezentsev and removed request for vlad-perevezentsev December 7, 2023 16:12
vtavana
vtavana approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@antonwolfy antonwolfy merged commit 9575363 into master Dec 7, 2023
@antonwolfy antonwolfy deleted the dpnp_diff branch December 7, 2023 18:10
github-actions bot added a commit to antonwolfy/dpnp that referenced this pull request Dec 8, 2023
@github-actions
Redesign dpnp.diff thorough existing calls (IntelPython#1637)
6393a1b 
* Redesigned `put_along_axis` and `take_along_axis` thorugh existing calls

* Redesigned `dpnp.diff` thorugh existing calls

* Proper resolving conflicts after rebase of master branch

* Increased tests coverage

* Fixed test_logspace_axis to be passed in wheels tests

* Resolved pre-commit issue 9575363
@antonwolfy antonwolfy mentioned this pull request Jan 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vtavana