Skip to content

Removed temporary workaround from dpnp.get_normalized_queue_device() #1605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Oct 20, 2023

The PR proposes to remove obsolete TODO from dpnp.get_normalized_queue_device() function.

Based on current run dependency on the dpctl version, we can always assume that normalize_queue_device is available and so the workaround with falling back on sycl_queue from input arguments can be safely removed.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2023

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy merged commit 38b0c4f into master Oct 20, 2023
@antonwolfy antonwolfy deleted the remove_todo_in_normalize_queue_device branch October 20, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants