Skip to content

Resolve gh-1046 #2097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 6, 2025
Merged

Resolve gh-1046 #2097

merged 3 commits into from
Jun 6, 2025

Conversation

ndgrigorian
Copy link
Collaborator

Closes gh-1046

This PR resolves dpt.asarray(x, device=dev) failing for some array x with dtype not supported by device dev

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

asarray now treats usm_ndarray the same as numpy arrays when the dtype of the array is not supported by targeted device
Copy link

github-actions bot commented Jun 5, 2025

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

antonwolfy
antonwolfy previously approved these changes Jun 5, 2025
Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In overall, LGTM
Thank you @ndgrigorian

Copy link

github-actions bot commented Jun 5, 2025

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_4 ran successfully.
Passed: 1114
Failed: 7
Skipped: 119

@coveralls
Copy link
Collaborator

coveralls commented Jun 5, 2025

Coverage Status

coverage: 84.978% (-0.006%) from 84.984%
when pulling 676e418 on resolve-gh-1046
into a26cac1 on master.

@ndgrigorian ndgrigorian requested a review from antonwolfy June 5, 2025 23:30
Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

github-actions bot commented Jun 5, 2025

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_5 ran successfully.
Passed: 1116
Failed: 5
Skipped: 119

Copy link

github-actions bot commented Jun 5, 2025

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_5 ran successfully.
Passed: 1114
Failed: 7
Skipped: 119

Copy link

github-actions bot commented Jun 6, 2025

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_6 ran successfully.
Passed: 1116
Failed: 5
Skipped: 119

@ndgrigorian ndgrigorian merged commit 556a5c6 into master Jun 6, 2025
70 of 73 checks passed
@ndgrigorian ndgrigorian deleted the resolve-gh-1046 branch June 6, 2025 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copying from device with float64 support to device without float64 support failed
3 participants