-
Notifications
You must be signed in to change notification settings - Fork 30
Resolve gh-1046 #2097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve gh-1046 #2097
Conversation
asarray now treats usm_ndarray the same as numpy arrays when the dtype of the array is not supported by targeted device
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In overall, LGTM
Thank you @ndgrigorian
Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_4 ran successfully. |
cf27c6a
to
9544e89
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_5 ran successfully. |
Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_5 ran successfully. |
Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_6 ran successfully. |
Closes gh-1046
This PR resolves
dpt.asarray(x, device=dev)
failing for some arrayx
with dtype not supported by devicedev