Skip to content

Install hwloc in SYCL OS compiler builds #2050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025

Conversation

ndgrigorian
Copy link
Collaborator

SYCL OS builds have been silently failing because of missing hwloc

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@ndgrigorian ndgrigorian force-pushed the install-hwloc-dpcpp-nightly-dependency branch from 1cd8bef to 267c235 Compare April 12, 2025 06:08
Copy link

github-actions bot commented Apr 12, 2025

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_141 ran successfully.
Passed: 1106
Failed: 4
Skipped: 119

@coveralls
Copy link
Collaborator

coveralls commented Apr 12, 2025

Coverage Status

coverage: 86.409%. remained the same
when pulling 267c235 on install-hwloc-dpcpp-nightly-dependency
into f3b70ed on master.

Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_142 ran successfully.
Passed: 1106
Failed: 4
Skipped: 119

Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_141 ran successfully.
Passed: 1106
Failed: 4
Skipped: 119

Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @ndgrigorian

@ndgrigorian ndgrigorian merged commit 2714ff2 into master Apr 14, 2025
106 of 107 checks passed
@ndgrigorian ndgrigorian deleted the install-hwloc-dpcpp-nightly-dependency branch April 14, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants