Skip to content

[MAINT] Fix building docs in CI #2044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2025
Merged

[MAINT] Fix building docs in CI #2044

merged 1 commit into from
Apr 9, 2025

Conversation

ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Apr 9, 2025 •
edited
Loading

Doc builds were failing in CI, citing setuptools version >=70.1 being required

Add setuptools">=70.1" to resolve

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@ndgrigorian ndgrigorian marked this pull request as ready for review April 9, 2025 03:52
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2025 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2025

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_114 ran successfully.
Passed: 913
Failed: 1
Skipped: 154

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 86.381%. remained the same
when pulling db59228 on fix-ci-doc-builds
into bc7a739 on master.

@ndgrigorian ndgrigorian merged commit f8c751b into master Apr 9, 2025
67 of 71 checks passed
@ndgrigorian ndgrigorian deleted the fix-ci-doc-builds branch April 9, 2025 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@antonwolfy antonwolfy Awaiting requested review from antonwolfy antonwolfy is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndgrigorian @coveralls @vtavana