Skip to content

Fix spacing in string representation of dpctl.SyclPlatform #2035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Apr 1, 2025

This PR removes an unnecessary space from dpctl.SyclPlatform.__repr__, fixing spacing in the string representation of dpctl.SyclPlatform

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

Copy link

github-actions bot commented Apr 1, 2025

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Copy link

github-actions bot commented Apr 1, 2025

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_84 ran successfully.
Passed: 894
Failed: 2
Skipped: 154

@coveralls
Copy link
Collaborator

coveralls commented Apr 1, 2025

Coverage Status

coverage: 86.378% (-0.001%) from 86.379%
when pulling 91b64c2 on fix-platform-repr-spacing
into 67317b0 on master.

@ndgrigorian ndgrigorian force-pushed the fix-platform-repr-spacing branch from 64fe028 to 91b64c2 Compare April 2, 2025 06:49
Copy link

github-actions bot commented Apr 2, 2025

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_102 ran successfully.
Passed: 894
Failed: 2
Skipped: 154

Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you @ndgrigorian

@ndgrigorian ndgrigorian enabled auto-merge April 2, 2025 15:57
@ndgrigorian ndgrigorian disabled auto-merge April 2, 2025 15:57
@ndgrigorian ndgrigorian merged commit 6f649bb into master Apr 2, 2025
65 of 69 checks passed
@ndgrigorian ndgrigorian deleted the fix-platform-repr-spacing branch April 2, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants