Set subprocess to no use fork #1971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Changes unknown |
|
@oleksandr-pavlyk |
Yes, the intent was that this be rebased after the PR for no-coverage is merged to eliminate duplicate commits |
oleksandr-pavlyk
force-pushed
the
set-subprocess-to-no-use-fork
branch
from
3b0b506 to
1985406
Compare
Fork is not supported by DPC++ runtime. Attempt to use fork may cause hangs, or incorrect behavior. In particular, it may affect working on oneapi-gdb. To enable smooth experience in debugging kernels launched by dpctl, or extensions built using dpctl C++ API, initialization of dpctl on Linux, imports subprocess and sets its configuration variables to use SPAWN over FORK https://docs.python.org/3/library/subprocess.html#disabling-use-of-vfork-or-posix-spawn
oleksandr-pavlyk
force-pushed
the
set-subprocess-to-no-use-fork
branch
from
1985406 to
af3347a
Compare
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_485 ran successfully. |
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_480 ran successfully. |
ndgrigorian
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modified initialization of
dpctlto set subprocess to not use FORK, but use SPAWN to launch subprocesses on Linux.This is a tentative fix to allows
oneapi-gdbto debug kernels submitted by Python applications.