Skip to content

Technical debt changes #1957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 10, 2025
Merged

Technical debt changes #1957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
620bdd0
Replace use of anonymous namespace in kernels/elementwise_functions h…
oleksandr-pavlyk Jan 8, 2025
87052e2
Replace use of anonymous namespace in headers
oleksandr-pavlyk Jan 8, 2025
869faef
Reduced number of created iota and map_back kernels
oleksandr-pavlyk Jan 8, 2025
80f288c
Move vectors ptrs and dels into host_task lambda
oleksandr-pavlyk Jan 8, 2025
08cfede
Moved local update kernels to separate function which take fewer temp…
oleksandr-pavlyk Jan 8, 2025
8c167bf
Add comment before call to unique_ptr::release method
oleksandr-pavlyk Jan 9, 2025
ce02c6c
Add comments explaining intention of unique_ptr::reset call
oleksandr-pavlyk Jan 9, 2025
fea54b6
Replace sycl::malloc_device with smart_malloc_device
oleksandr-pavlyk Jan 9, 2025
9841f9e
Change signature of copy_and_cast_from_host_impl and copy_for_reshape…
oleksandr-pavlyk Jan 9, 2025
9d77faf
Change to device_allocate_and_pack to return unique_ptr
oleksandr-pavlyk Jan 9, 2025
065413e
Merge _sorting_impl and _sorting_radix_impl modules
oleksandr-pavlyk Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 2 additions & 14 deletions dpctl/tensor/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,12 +114,10 @@ set(_reduction_sources
set(_sorting_sources
${CMAKE_CURRENT_SOURCE_DIR}/libtensor/source/sorting/merge_sort.cpp
${CMAKE_CURRENT_SOURCE_DIR}/libtensor/source/sorting/merge_argsort.cpp
${CMAKE_CURRENT_SOURCE_DIR}/libtensor/source/sorting/searchsorted.cpp
${CMAKE_CURRENT_SOURCE_DIR}/libtensor/source/sorting/topk.cpp
)
set(_sorting_radix_sources
${CMAKE_CURRENT_SOURCE_DIR}/libtensor/source/sorting/radix_sort.cpp
${CMAKE_CURRENT_SOURCE_DIR}/libtensor/source/sorting/radix_argsort.cpp
${CMAKE_CURRENT_SOURCE_DIR}/libtensor/source/sorting/searchsorted.cpp
${CMAKE_CURRENT_SOURCE_DIR}/libtensor/source/sorting/topk.cpp
)
set(_static_lib_sources
${CMAKE_CURRENT_SOURCE_DIR}/libtensor/source/simplify_iteration_space.cpp
Expand Down Expand Up @@ -156,10 +154,6 @@ set(_tensor_sorting_impl_sources
${CMAKE_CURRENT_SOURCE_DIR}/libtensor/source/tensor_sorting.cpp
${_sorting_sources}
)
set(_tensor_sorting_radix_impl_sources
${CMAKE_CURRENT_SOURCE_DIR}/libtensor/source/tensor_sorting_radix.cpp
${_sorting_radix_sources}
)
set(_linalg_sources
${CMAKE_CURRENT_SOURCE_DIR}/libtensor/source/elementwise_functions/elementwise_functions_type_utils.cpp
${CMAKE_CURRENT_SOURCE_DIR}/libtensor/source/linalg_functions/dot.cpp
Expand Down Expand Up @@ -214,12 +208,6 @@ add_sycl_to_target(TARGET ${python_module_name} SOURCES ${_tensor_sorting_impl_s
target_link_libraries(${python_module_name} PRIVATE ${_static_lib_trgt})
list(APPEND _py_trgts ${python_module_name})

set(python_module_name _tensor_sorting_radix_impl)
pybind11_add_module(${python_module_name} MODULE ${_tensor_sorting_radix_impl_sources})
add_sycl_to_target(TARGET ${python_module_name} SOURCES ${_tensor_sorting_radix_impl_sources})
target_link_libraries(${python_module_name} PRIVATE ${_static_lib_trgt})
list(APPEND _py_trgts ${python_module_name})

set(python_module_name _tensor_linalg_impl)
pybind11_add_module(${python_module_name} MODULE ${_tensor_linalg_impl_sources})
add_sycl_to_target(TARGET ${python_module_name} SOURCES ${_tensor_linalg_impl_sources})
Expand Down
8 changes: 3 additions & 5 deletions dpctl/tensor/_sorting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,16 +25,14 @@
from ._tensor_sorting_impl import (
_argsort_ascending,
_argsort_descending,
_sort_ascending,
_sort_descending,
_topk,
)
from ._tensor_sorting_radix_impl import (
_radix_argsort_ascending,
_radix_argsort_descending,
_radix_sort_ascending,
_radix_sort_descending,
_radix_sort_dtype_supported,
_sort_ascending,
_sort_descending,
_topk,
)

__all__ = ["sort", "argsort"]
Expand Down
Loading
Loading